feat: added support for lts/* syntax in nvmrc
#1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To help me better understand the codebase, I added a test for the |
|
Hey, thanks for this contribution, we greatly appreciate it! I'll let the applicable people comment on the technical side of it. But for now, it would be great if you could also update the docs side of things to reflect your additions! |
|
Hi @brody192, There was no mention for |
|
Awsome, thanks! looks good. |
coffee-cup
approved these changes
Dec 4, 2024
| @@ -407,6 +407,47 @@ mod test { | |||
| assert_eq!(result, env_plan); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_to_json_and_from_json() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1190
PR Checklist